f

tool/playwright.py

@@ -174,30 +174,49 @@ class PlaywrightTool:
         ignore_https = bool(_get("ignore_https_errors", defaults.ignore_https_errors))
 
         # Try to find ffmpeg: config override, environment variable, bundled, then system
+        # This checks if ffmpeg is actually available (not just the path to it)
         ffmpeg_path: Optional[str] = None
         config_ffmpeg = _get("ffmpeg_path", None)
+        
         if config_ffmpeg:
-            ffmpeg_path = str(config_ffmpeg).strip()
-        else:
+            # User explicitly configured ffmpeg path
+            candidate = str(config_ffmpeg).strip()
+            if Path(candidate).exists():
+                ffmpeg_path = candidate
+            else:
+                debug(f"Configured ffmpeg path does not exist: {candidate}")
+        
+        if not ffmpeg_path:
             # Check environment variable (supports project ffmpeg)
             env_ffmpeg = os.environ.get("PLAYWRIGHT_FFMPEG_PATH")
-            if env_ffmpeg:
+            if env_ffmpeg and Path(env_ffmpeg).exists():
                 ffmpeg_path = env_ffmpeg
+            elif env_ffmpeg:
+                debug(f"PLAYWRIGHT_FFMPEG_PATH set but path does not exist: {env_ffmpeg}")
+        
+        if not ffmpeg_path:
+            # Try to find bundled ffmpeg in the project (Windows-only, in MPV/ffmpeg/bin)
+            try:
+                repo_root = Path(__file__).resolve().parent.parent
+                bundled_ffmpeg = repo_root / "MPV" / "ffmpeg" / "bin"
+                if bundled_ffmpeg.exists():
+                    ffmpeg_exe = bundled_ffmpeg / ("ffmpeg.exe" if os.name == "nt" else "ffmpeg")
+                    if ffmpeg_exe.exists():
+                        ffmpeg_path = str(ffmpeg_exe)
+                        debug(f"Found bundled ffmpeg at: {ffmpeg_path}")
+            except Exception as e:
+                debug(f"Error checking for bundled ffmpeg: {e}")
+        
+        if not ffmpeg_path:
+            # Try system ffmpeg if bundled not found
+            system_ffmpeg = shutil.which("ffmpeg")
+            if system_ffmpeg:
+                ffmpeg_path = system_ffmpeg
+                debug(f"Found system ffmpeg at: {ffmpeg_path}")
             else:
-                # Try to find bundled ffmpeg in the project (if available)
-                try:
-                    repo_root = Path(__file__).resolve().parent.parent
-                    bundled_ffmpeg = repo_root / "MPV" / "ffmpeg" / "bin"
-                    if bundled_ffmpeg.exists():
-                        ffmpeg_exe = bundled_ffmpeg / ("ffmpeg.exe" if os.name == "nt" else "ffmpeg")
-                        if ffmpeg_exe.exists():
-                            ffmpeg_path = str(ffmpeg_exe)
-                except Exception:
-                    pass
-                
-                # Try system ffmpeg if bundled not found
-                if not ffmpeg_path:
-                    ffmpeg_path = shutil.which("ffmpeg")
+                # ffmpeg not found - log a debug message but don't fail
+                # ffmpeg-python may still work with system installation, or user might not need it
+                debug("ffmpeg not found on PATH. For best compatibility, install ffmpeg: Windows (use bundled or choco install ffmpeg), macOS (brew install ffmpeg), Linux (apt install ffmpeg or equivalent)")
 
         return PlaywrightDefaults(
             browser=browser,
@@ -219,6 +238,26 @@ class PlaywrightTool:
                 "playwright is required; install with: pip install playwright; then: playwright install"
             )
 
+    def ffmpeg_available(self) -> bool:
+        """Check if ffmpeg is available on the system."""
+        return bool(self.defaults.ffmpeg_path)
+    
+    def require_ffmpeg(self) -> None:
+        """Require ffmpeg to be available; raise a helpful error if not.
+        
+        This should be called before operations that need ffmpeg (e.g., video recording).
+        """
+        if not self.ffmpeg_available():
+            raise RuntimeError(
+                "ffmpeg is required but not found on your system.\n"
+                "Install it using:\n"
+                "  Windows: choco install ffmpeg (if using Chocolatey) or use the bundled version in MPV/ffmpeg\n"
+                "  macOS: brew install ffmpeg\n"
+                "  Linux: apt install ffmpeg (Ubuntu/Debian) or equivalent for your distribution\n"
+                "\n"
+                "Or set the PLAYWRIGHT_FFMPEG_PATH environment variable to point to your ffmpeg executable."
+            )
+
     @contextlib.contextmanager
     def open_page(
         self,