ff

SYS/result_table.py

@@ -136,7 +136,19 @@ def _get_first_dict_value(data: Dict[str, Any], keys: List[str]) -> Any:
 
 
 def _as_dict(item: Any) -> Optional[Dict[str, Any]]:
-    if isinstance(item, dict):
+    """Convert any object to dictionary representation.
+    
+    Handles:
+    - Dict objects (returned as-is)
+    - Objects with __dict__ attribute (converted to dict)
+    - None or conversion failures (returns None)
+    
+    Args:
+        item: Object to convert (dict, dataclass, object, etc.)
+        
+    Returns:
+        Dictionary representation or None if conversion fails
+    """
         return item
     try:
         if hasattr(item, "__dict__"):
@@ -148,7 +160,17 @@ def _as_dict(item: Any) -> Optional[Dict[str, Any]]:
 
 
 def extract_store_value(item: Any) -> str:
-    data = _as_dict(item) or {}
+    """Extract storage backend name from item.
+    
+    Searches item for store identifier using multiple field names:
+    store, table, source, storage (legacy).
+    
+    Args:
+        item: Object or dict with store information
+        
+    Returns:
+        Store name as string (e.g., "hydrus", "local", "") if not found
+    """
     store = _get_first_dict_value(
         data,
         ["store",
@@ -1959,7 +1981,33 @@ def format_result(result: Any, title: str = "") -> str:
 def extract_item_metadata(item: Any) -> Dict[str, Any]:
     """Extract a comprehensive set of metadata from an item for the ItemDetailView.
     
-    Now supports SYS.result_table_api.ResultModel as a first-class input.
+    Converts items (ResultModel, dicts, objects) into normalized metadata dict.
+    Extracts all relevant fields for display: Title, Hash, Store, Path, Ext, Size,
+    Duration, URL, Relations, Tags.
+    
+    Optimization:
+    - Calls _as_dict() only once and reuses throughout
+    - Handles both ResultModel objects and legacy dicts/objects
+    
+    Example output:
+        {
+            "Title": "video.mp4",
+            "Hash": "abc123def456...",
+            "Store": "hydrus",
+            "Path": "/mnt/media/video.mp4",
+            "Ext": "mp4",
+            "Size": "1.2 GB",
+            "Duration": "1h23m",
+            "Url": "https://example.com/video.mp4",
+            "Relations": <null>,
+            "Tags": "movie, comedy"
+        }
+    
+    Args:
+        item: Object to extract metadata from (ResultModel, dict, or any object)
+        
+    Returns:
+        Dictionary with standardized metadata fields (empty dict if None input)
     """
     if item is None:
         return {}
@@ -1996,13 +2044,15 @@ def extract_item_metadata(item: Any) -> Dict[str, Any]:
         return out
 
     # Fallback to existing extraction logic for legacy objects/dicts
+    # Convert once and reuse throughout to avoid repeated _as_dict() calls
+    data = _as_dict(item) or {}
+    
     # Use existing extractors from match-standard result table columns
     title = extract_title_value(item)
     if title: 
         out["Title"] = title
     else:
         # Fallback for raw dicts
-        data = _as_dict(item) or {}
         t = data.get("title") or data.get("name") or data.get("TITLE")
         if t: out["Title"] = t
     
@@ -2013,7 +2063,6 @@ def extract_item_metadata(item: Any) -> Dict[str, Any]:
     if store: out["Store"] = store
     
     # Path/Target
-    data = _as_dict(item) or {}
     path = data.get("path") or data.get("target") or data.get("filename")
     if path: out["Path"] = path
     
@@ -2066,6 +2115,23 @@ class ItemDetailView(Table):
 
     This is used for 'get-tag', 'get-url' and similar cmdlets where we want to contextually show
     what is being operated on (the main item) along with the selection list.
+    
+    Display structure:
+        ┌─ Item Details Panel ─────────────────────────────┐
+        │ Title:     video.mp4                              │
+        │ Hash:      abc123def456789...                     │
+        │ Store:     hydrus                                 │
+        │ Path:      /media/video.mp4                       │
+        │ Ext:       mp4                                    │
+        │ Url:       https://example.com/video.mp4          │
+        └────────────────────────────────────────────────────┘
+        
+        # TAGS              Value
+        1  .jpg            
+        2  .png            
+        3  .webp           
+    
+    Used by action cmdlets that operate on an item and show its related details.
     """
 
     def __init__(